-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DrawPanel Update: Moving repetitive functions to helpers #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganimtron-10
changed the title
DrawPanel Update: Moving repetitive functions to helpers
[WIP] DrawPanel Update: Moving repetitive functions to helpers
Sep 3, 2022
Codecov Report
@@ Coverage Diff @@
## master #679 +/- ##
==========================================
- Coverage 50.40% 50.39% -0.01%
==========================================
Files 120 120
Lines 26980 27046 +66
Branches 2986 2992 +6
==========================================
+ Hits 13598 13629 +31
- Misses 12923 12957 +34
- Partials 459 460 +1
|
ganimtron-10
changed the title
[WIP] DrawPanel Update: Moving repetitive functions to helpers
DrawPanel Update: Moving repetitive functions to helpers
Sep 6, 2022
skoudoro
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, Thank you @ganimtron-10, merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some code from the
DrawShape
UI is going to be reused in the Grouping Shape Feature #653 .So to avoid these repetitive codes, moving them into
helper.py
file.