Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implementation of PBR in glTF #715

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xtanion
Copy link
Member

@xtanion xtanion commented Dec 10, 2022

This PR needs a lot of cleaning and still in progress. As of now this PR adds ORM, Normal & Emissive materials. Most of the glTF models has been modified to use the ORM material, however few of them still use MetallicRoughness and AmbientOcclusion materials separately (for e.g. DamagedHelmet & Avocado).
Few model may have RoughnessMetallic instead of MetallicRoughness which changes switches the channels (For e.g. the Avocado model), as mentioned in this comment. This PR currently does not support the RoughnessMetallic.

Preview with the DamagedHelmet (has all three of materials) model:
image

Sample of the Avocado model (without switching the channels in RoughnessMetallic to MetallicRoughness) ( Left)
After switching channels (Right):

@Garyfallidis
Copy link
Contributor

Garyfallidis commented Dec 10, 2022

Very impressive !!! Emissive seems working very well.

@Garyfallidis
Copy link
Contributor

Why the colors are so dark on the helmet? The correct rendering should look like this...

image

From the description above I am not sure where the issue is.

@Garyfallidis
Copy link
Contributor

Above IBL is on. This is how it should look without IBL.

image

@Garyfallidis
Copy link
Contributor

@xtanion this PR needs rebasing. We should resume the glft/pbr meeting too @guaje

@Garyfallidis
Copy link
Contributor

@xtanion please resolve conflicts and let's move to the final steps of Gltf support. @guaje let's meet asap!

@xtanion
Copy link
Member Author

xtanion commented Mar 4, 2023

Sorry for the late reply @Garyfallidis, my school examinations were going on. I'll fix this ASAP.

@Garyfallidis
Copy link
Contributor

Ping @xtanion Let us know if you need a meeting to finalize this.

@Garyfallidis
Copy link
Contributor

@xtanion please provide feedback asap.

@xtanion
Copy link
Member Author

xtanion commented Mar 22, 2023

Sorry for the late response, I was traveling this entire week. I'll be working on this from Friday.

@skoudoro
Copy link
Contributor

Sorry for the late response, I was traveling this entire week. I'll be working on this from Friday.

Great! Do you have any progress on this? if yes, can you push it?

thank you @xtanion.

ps: Also, it would be great if you could attend the fury open meeting this Thursday (March 30)

@skoudoro
Copy link
Contributor

skoudoro commented Apr 6, 2023

ping @xtanion

@Garyfallidis
Copy link
Contributor

There are still some conflicts. Can you also list the remaining steps needed for this PR? @xtanion ?

@Garyfallidis
Copy link
Contributor

@xtanion a reminder to move forward with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants