Ellipsoid actor implemented with SDF

[tvcastillod]

Hi, this PR aims to create a new ellipsoid actor defined with SDF and raymarching. The goal is to make an implementation that allows displaying a large amount of data, with good visual quality, and without compromising performance. I'm still working on improvements and ways to test the implementation.

[skoudoro]

Hi @guaje,

I see that you requested a review from all but I see that this PR is a draft with WIP tag.

Is this PR ready for review? What is the status ? @tvcastillod, can you answer also ?

[tvcastillod]

Is this PR ready for review? What is the status ? @tvcastillod, can you answer also ?

@skoudoro Not yet. I was waiting for today's meeting to know how to proceed with this PR, I received some comments that I will address soon, and when ready I will change the status and request the review again.

[skoudoro]

Thank you for the feedback!

[skoudoro]

Hi @tvcastillod,

Here is an initial review. I will try a bit later your PR

[codecov]

Codecov Report

Merging #791 (0a49b68) into master (73e0a1a) will decrease coverage by 0.09%.
The diff coverage is 78.04%.

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   84.41%   84.33%   -0.09%     
==========================================
  Files          43       44       +1     
  Lines       10166    10356     +190     
  Branches     1381     1410      +29     
==========================================
+ Hits         8582     8734     +152     
- Misses       1227     1252      +25     
- Partials      357      370      +13     

Impacted Files	Coverage Δ
fury/actor.py	85.59% <41.93%> (-1.20%)	⬇️
fury/actors/tensor.py	100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

[skoudoro]

Great job @tvcastillod, Looks good to me.

I have few questions below to clarify or correct and then I think this PR will be ready to be merged.

[tvcastillod]

@skoudoro @guaje would you mind taking a last look to see if there is anything else I need to adjust?

[skoudoro]

@JoaoDell, Can you look and review the shader part.

@ganimtron-10, can you look and review the python part.

Both, please, let @tvcastillod knows if you have any questions or if you see something.

After that, we can go ahead and merge this PR.

[JoaoDell]

Just finished reviewing mainly the shader part. The tests worked and sucessfully rendered the ellipsoids, so it is working. I just got some questions to better understand some choices, but everything seems fine 👍

[ganimtron-10]

Hey @tvcastillod,
I had the few below comments. Please them out then it would be ready to go.

[tvcastillod]

@skoudoro I did all the requested changes, I think now it is ready.

[skoudoro]

Thank you for this work @tvcastillod.

Thank you for the review @JoaoDell, @ganimtron-10 and @guaje. It is good to have other pair of eye

merging