Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add wachiou's week 2 blog post #897

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

WassCodeur
Copy link
Contributor

Add my week 2 blog post

FIX: remove trailing-whitespace

DOC: function names warn_on_args_to_kwargs and keyword_only as inline code
Copy link
Member

@robinroy03 robinroy03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving. See the comments below for some improvement.

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WassCodeur,

All looks good merging.

Note: your blog posts should starts to be a bit more technical and less generic. Explain more in detail what you understand, challenges, etc...

@skoudoro skoudoro merged commit 06d2cd9 into fury-gl:master Jun 24, 2024
8 of 29 checks passed
@itellaetxe
Copy link

itellaetxe commented Jun 25, 2024

Apologies @WassCodeur @skoudoro, I could not review this on time. I will for sure do it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants