Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Support for scopes npm packages in arithmetic instructions #301

Closed
jrmyio opened this issue Feb 24, 2017 · 1 comment
Closed

Support for scopes npm packages in arithmetic instructions #301

jrmyio opened this issue Feb 24, 2017 · 1 comment
Milestone

Comments

@jrmyio
Copy link

jrmyio commented Feb 24, 2017

Npm allows scopes to be used which makes packages have names like "@blueprint/core". However, the arithmetic instructions does not support this and doesn't recognize "@blueprint/core" as an npm package because of https://github.com/fuse-box/fuse-box/blob/master/src/Arithmetic.ts#L124.

In other words, >app.tsx -@blueprint/core incorrectly bundles the @blueprint/core npm package.

https://docs.npmjs.com/misc/scope "A scope follows the usual rules for package names (url-safe characters, no leading dots or underscores). When used in package names, preceded by an @-symbol and followed by a slash, e.g."

Better to verify an npm package name by using:
https://github.com/npm/validate-npm-package-name

nchanged pushed a commit that referenced this issue Feb 24, 2017
@nchanged
Copy link
Contributor

// npm install react-addons-css-transition-group react react-dom @blueprintjs/core 
app.devServer(`
    > index.ts 
    + @blueprintjs/core 
`);

nchanged pushed a commit that referenced this issue Feb 24, 2017
@nchanged nchanged added this to the 1.3.122 milestone Feb 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants