This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
fix: sparky path executed in sub folders #1582 #1628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nchanged
Think Ive found the root of my issue.
Need to test more and find a good way to add test to this. I only ran the sparky tests.
Problem is when its started from package root with something like npm or directly
node ./projects/sample1/fuse.ts
If I tried to run this nothing happend, because it didnt find it.
This is why I added option cwd to GLOB.
Changed the ROOT app since files didnt end up relative to script using sparky.
If Ive broken something I dont know atm.
But like I started, we need to add more tests before we merge.
Maybe CI finds something when I create the PR too 😂
Its late, I need sleep now.