Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

fix: sparky path executed in sub folders #1582 #1628

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Conversation

vegarringdal
Copy link
Member

@nchanged

Think Ive found the root of my issue.
Need to test more and find a good way to add test to this. I only ran the sparky tests.

Problem is when its started from package root with something like npm or directly node ./projects/sample1/fuse.ts

If I tried to run this nothing happend, because it didnt find it.
This is why I added option cwd to GLOB.
Changed the ROOT app since files didnt end up relative to script using sparky.

// failing, but dont know why
task("copy-src", async context => {
  await src(`./src/**/*.*`)
    .dest('./dist3/ts', `/src/`) 
    .exec();
});

If Ive broken something I dont know atm.
But like I started, we need to add more tests before we merge.
Maybe CI finds something when I create the PR too 😂
Its late, I need sleep now.

@@ -37,7 +37,7 @@ export function sparkyChain(log: FuseBoxLogAdapter): ISparkyChain {
}

if (newLocation && newLocationBase) {
const root = ensureAbsolutePath(newLocation, env.APP_ROOT);
const root = ensureAbsolutePath(newLocation, env.SCRIPT_PATH);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that's what It should be.. I never had problems cuz fuse.ts is usually at the root ;-)

@nchanged nchanged merged commit f13bc29 into master Sep 10, 2019
@nchanged nchanged deleted the vr-sparky-path branch November 15, 2019 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants