Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package to Stackage snapshot #75

Closed
patrickt opened this issue Nov 19, 2018 · 8 comments
Closed

Add package to Stackage snapshot #75

patrickt opened this issue Nov 19, 2018 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@patrickt
Copy link
Collaborator

We’re on hackage, so there’s no reason we shouldn’t be on stackage.

As asked for in #74.

@patrickt patrickt added enhancement New feature or request help wanted Extra attention is needed labels Nov 19, 2018
@robrix
Copy link
Contributor

robrix commented Nov 23, 2018

Per #74 (comment), my only concern is whether it’ll be a problem that we aren’t promising API stability yet.

@jkachmar
Copy link
Contributor

jkachmar commented Nov 26, 2018

FWIW, Stackage doesn't particularly "care" about API stability.

It's more of a way to get your packages included in a package set that's part of a continuous integration process (i.e. compile against all the other dependencies in the snapshot, run tests, and generate haddocks) that notifies the listed maintainer when/if something goes wrong.

For example, if you were to put yourself down as the Stackage maintainer for fused-effects and the test suite were to break, or some dependency were to bump its version beyond the bounds you specify, a Stackage Curator would make an issue notifying you of the change (or even PRing an update if it's reasonable/they have the time).

EDIT: Full disclosure, I'm a Stackage Curator, so I'm biased in favor of this system 😄

@mbj
Copy link

mbj commented Nov 26, 2018

Full disclosure: I'm a stackage user, and I do not care about api stability more than I know in advance packages I pull from stackage compile against each other - in a given snapshot.

And thank you for @jkachmar for being a stackage curator, allowing me to benefit of this guarantee.

@patrickt
Copy link
Collaborator Author

@robrix My $0.02: I think it’s fine that we aren’t making strict API stability guarantees before v1.0.0. How would you feel about making a note of this in the README and then putting this into the next Stackage release?

@robrix
Copy link
Contributor

robrix commented Nov 27, 2018

@jkachmar @mbj: Thank you for the feedback!

@patrickt: that’s a good plan 👍

@mbj
Copy link

mbj commented Nov 27, 2018

@patrickt: that’s a good plan +1

Thank you for your work on the package. I may have some detailed feedback later. So far I really like it.

@patrickt
Copy link
Collaborator Author

Underway in commercialhaskell/stackage#4191

@patrickt
Copy link
Collaborator Author

patrickt commented Dec 2, 2018

https://www.stackage.org/nightly-2018-12-01/package/fused-effects-0.1.2.0

@patrickt patrickt closed this as completed Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants