Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 8.6.2 #74

Merged
merged 3 commits into from Nov 23, 2018
Merged

Support GHC 8.6.2 #74

merged 3 commits into from Nov 23, 2018

Conversation

jkachmar
Copy link
Contributor

This adds support and CI coverage for GHC 8.6.2.

If this looks good, and CI passes smoothly, would you be amenable to this package being added to the Stackage nightly snapshots?

@jkachmar jkachmar changed the title Supports GHC 8.6.2 Support GHC 8.6.2 Nov 19, 2018
@patrickt
Copy link
Collaborator

This looks good to me.

@jkachmar, I’ve opened an issue for Stackage. @robrix is on vacation right now, but I think he’ll be amenable to it - we want people to use this package, after all!

@patrickt
Copy link
Collaborator

Not sure why this is wedged in the builders.

@robrix
Copy link
Contributor

robrix commented Nov 23, 2018

@patrickt: I selected the wrong job in the branch protection settings. Fixed that.

@robrix robrix merged commit 32c4975 into fused-effects:master Nov 23, 2018
@robrix
Copy link
Contributor

robrix commented Nov 23, 2018

Thanks so much @jkachmar!

If this looks good, and CI passes smoothly, would you be amenable to this package being added to the Stackage nightly snapshots?

I’ve no objection so long as they’re cool with having a 0.x package in there. (In particular, we aren’t promising API stability quite yet.)

@jkachmar
Copy link
Contributor Author

Thanks for getting this merged in!

I don't think there should be any objection to API stability, and once the updated version is published to Hackage I can run the Stackage curator again to make sure that everything works together.

How would you like the attribution/maintainership to be set up in Stackage?

e.g. @patrickt is the Stackage maintainer for postgresql-transactional and so shows up in the build-constraints file like this: https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml#L2798-L2799

@robrix
Copy link
Contributor

robrix commented Nov 30, 2018

@jkachmar: Could you make me the maintainer, with robrix@github.com for the email address please? 🙏

@robrix
Copy link
Contributor

robrix commented Nov 30, 2018

(I’ve just published 0.1.2.0 to hackage today: http://hackage.haskell.org/package/fused-effects-0.1.2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants