Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses generic derivation for reinterpret log example #178

Merged
merged 1 commit into from Jun 13, 2019
Merged

Uses generic derivation for reinterpret log example #178

merged 1 commit into from Jun 13, 2019

Conversation

jkachmar
Copy link
Contributor

The ReinterpretLog example had a comment mentioning that generic derivation of HFunctor and Effect for first-order effects wasn't possible at the time, and linked to an issue (#54) that has since been closed (#170).

This PR updates the example with a generic derivation for these effects and removes the comment, which is no longer applicable.

@jkachmar
Copy link
Contributor Author

Funny thing is that I was originally going to try and create some fused-effects-th package to automatically gin up these instances + the helper functions (like polysemy does) when I looked at the Teletype example and realized that you'd already built-in a way nicer solution for the instances stuff 😂

Copy link
Contributor

@robrix robrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful. Thank you so much @jkachmar!

@robrix robrix merged commit 2bf10ce into fused-effects:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants