-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a oneOf
function to improve the ergonomics of NonDet.
#201
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2c11e1d
Add a `choose` function to improve the ergonomics of NonDet.
patrickt 15de0ab
Merge branch 'master' into add-choose
patrickt a80d12a
Merge branch 'master' into add-choose
robrix e5df64a
Add changelog entry.
patrickt 8540a9d
Rename `choose` to `oneOf`.
patrickt ddac016
Merge branch 'master' into add-choose
patrickt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about doing
foldMapA
instead? I personally find it much more generally useful, and it still enjoys good type inference properties.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections at all to exposing
foldMapA
as well aschoose
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At that point, given that
choose = foldMapA pure
, it seems like we don’t gain much from including both. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m a big fan of providing a single verb for “choose an element of this structure”, for a few reasons: both because I find existing
foldMapA pure
orasum . fmap pure
patterns unreadable, or at best non-obvious, and also because I think this operation is extremely common. (I’ve been practicing some simple logic programs recently, and I neededchoose
in all of them.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, makes sense 👍
What do you think about renaming it to not conflict with #198’s smart constructor? Perhaps
oneOf
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oneOf
is fine by me.choose
was a little too close tochoice
fromparsers
. Will make the change!