Writer space leak fix #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickt
reviewed
Jan 5, 2019
|
|
||
|
|
||
| newtype WriterC w m a = WriterC { runWriterC :: m (w, a) } | ||
| newtype WriterC w m a = WriterC { runWriterC :: w -> m (w, a) } |
There was a problem hiding this comment.
Can we make some notes in the documentation (doesn’t have to be Haddock) about why we chose this formulation?
fused-effects.cabal
Outdated
| , fused-effects | ||
| hs-source-dirs: benchmark | ||
| default-language: Haskell2010 | ||
| ghc-options: -threaded -rtsopts "-with-rtsopts=-N -A4m -n2m" -j |
There was a problem hiding this comment.
Unfortunately that causes cabal check to complain. Plus, I think it’s valuable to be able to run the benchmarks at different optimization levels and see how the performance varies.
There was a problem hiding this comment.
Weird re. cabal check, but good enough for me.
|
@patrickt: Documented with a link to the mailing list post, and also noted the current limitations. |
|
Looks terrific. |
patrickt
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Functor,Applicative, andMonadinstances forVoidCandWriterC.WriterC/VoidCagainst theirEff-wrapped counterparts. (cf Eff is slower than the underlying carrier for some operations #89)