Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyo3 feature forwarding #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jam1garner
Copy link

This is to allow users to directly control the features of the pyo3 instance used by inline-python without adding it as a direct dependency (and thus risking the versions of pyo3 drifting out of date without pinning both libraries versions). This is especially useful as inline-python re-exports pyo3.

The format used is "pyo3-{featurename}", following the kebab case of pyo3's features.

@de-vri-es
Copy link
Contributor

Hey, thanks for the PR! I can certainly see the point of this, but I'm a little worried that we'll forget to keep it in sync in the future.

@m-ou-se: What do you think?

@jam1garner
Copy link
Author

If keeping all the features in sync is a worry I would, at minimum, recommend forwarding the macros feature—without it you lose a lot of the ability to integrate with pyo3 (exposing user types/functions to python)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants