Support reverse from Django 2.0 #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvass
force-pushed
the
urlresolvers_django2
branch
2 times, most recently
from
73d1597
to
ed7cb31
Compare
|
@gavinwahl friendly ping. Could you review this PR? |
|
@gavinwahl could you reviewing my PR? |
|
Also pinging on this, the branch works well for us too. |
gavinwahl
reviewed
Jun 22, 2018
| @@ -8,3 +8,4 @@ pep8.txt | |||
| dist/ | |||
| build/ | |||
| .tox | |||
| venv/ | |||
There was a problem hiding this comment.
I didn't find any environment directory name and added venv.
gavinwahl
reviewed
Jun 22, 2018
|
@gavinwahl tox was not working with travis ci please see https://travis-ci.org/fusionbox/django-absoluteuri/builds/340116977?utm_source=github_status&utm_medium=notification |
|
@gavinwahl do you have a time for review this PR and bump version? kind regards! |
|
I believe it is time to approve this. What do you think? Let's update python and django versions? |
|
fixed in fc377ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The django.core.urlresolvers module is removed in favor of its new location, django.urls.
Closes #8