Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Match <Route> props API with react-router #132

Merged
merged 3 commits into from
May 2, 2018

Conversation

dennisgl
Copy link
Contributor

@dennisgl dennisgl commented May 2, 2018

Reference: https://github.com/ReactTraining/react-router/blob/v4.3.0-rc.3/packages/react-router/modules/Route.js#L118-L127

Issues: Previously, to support <Router onRoute={() => {}}>, we made use of <ReactRouterRoute render and rejected <Route render. In addition, we dropped support for <Route children as a render prop.

Main changes: support props.render and props.children(as a function/render prop)

@dennisgl dennisgl requested a review from ganemone May 2, 2018 19:48
@dennisgl dennisgl changed the title align <Route> props API with react-router Align <Route> props API with react-router May 2, 2018
@dennisgl dennisgl changed the title Align <Route> props API with react-router Comply <Route> props API with react-router May 2, 2018
@codecov
Copy link

codecov bot commented May 2, 2018

Codecov Report

Merging #132 into master will decrease coverage by 0.6%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage      75%   74.39%   -0.61%     
==========================================
  Files           6        6              
  Lines         160      164       +4     
  Branches       37       39       +2     
==========================================
+ Hits          120      122       +2     
- Misses         26       28       +2     
  Partials       14       14
Impacted Files Coverage Δ
src/modules/Route.js 72.22% <61.53%> (-6.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112d998...b63d2a5. Read the comment docs.

@dennisgl dennisgl changed the title Comply <Route> props API with react-router Match <Route> props API with react-router May 2, 2018
Copy link
Contributor

@KevinGrandon KevinGrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, nice job!

@dennisgl
Copy link
Contributor Author

dennisgl commented May 2, 2018

!merge

@old-fusion-bot old-fusion-bot bot merged commit 5543928 into fusionjs:master May 2, 2018
@dennisgl dennisgl mentioned this pull request May 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants