This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix docs for <Route> #133
Merged
Fix docs for <Route> #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexMSmithCA
reviewed
May 2, 2018
README.md
Outdated
| @@ -131,7 +131,7 @@ Provide the UniversalEventsToken when you would like to emit routing events for | |||
|
|
|||
| #### Router | |||
|
|
|||
| Configures a router and acts as a React context provider for routing concerns. You don't need to use a Router component if you use `getRouter` | |||
| Configures a router and acts as a React context provider for routing concerns. It's unlikely you have use the component, given the plugin already provides `<Router>`. | |||
There was a problem hiding this comment.
Reword necessary?
It's unlikely you have use the component
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
+ Coverage 74.39% 75% +0.6%
=======================================
Files 6 6
Lines 164 164
Branches 39 39
=======================================
+ Hits 122 123 +1
+ Misses 28 27 -1
Partials 14 14
Continue to review full report at Codecov.
|
lhorie
approved these changes
May 3, 2018
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflecting changes made in #132 plus minor formattings