Skip to content
This repository has been archived by the owner on Aug 1, 2018. It is now read-only.

Fix inconsistencies in documentation and code #116

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

derekjuber
Copy link
Contributor

Fixes #96

Switched documentation default of defer to false and also changed the code for prepared to reference the first argument as sideEffect, matching the documentation, as opposed to prepare.

Using sideEffect made the code more readable IMO since there's already a prepare source file and different conjugations of the word already used in the same file.

@codecov
Copy link

codecov bot commented Jul 20, 2018

Codecov Report

Merging #116 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #116   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files           9        9           
  Lines         146      146           
  Branches       34       34           
=======================================
  Hits          114      114           
  Misses         21       21           
  Partials       11       11
Impacted Files Coverage Δ
src/prepared.js 83.33% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261ff8c...e142bc7. Read the comment docs.

@derekjuber
Copy link
Contributor Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit 3ca55f4 into fusionjs:master Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants