This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes to properly handle an error you need access to the initial
request context. This PR adds initialArgs to the error payload.
An example of when this is necessary is a single reducer that stores the
results of multiple API requests under different keys. For example:
Under the current framework, if we handle an error in our reducer, we
don't know whether the error is tied to a, b, or c. One way to solve
this is to have a handler on the server try/catch and return an
identifier (e.g. A), but this is not always possible. If a timeout or
network error occurred, the handler on the server might not even be
invoked and therefore wouldn't have the opportunity to provide an
indentifier to the request.
Another way of handling this would be for us to write our own
thunk-style handler for RPCs, but this seems against the spirit of
Fusion.
By exposing initialArgs, we can do:
Incidentally, this partially fixes #136.