1356721 - Filter/Validate hosts aren't already deploying #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cfchase
commented
Jul 22, 2016
cfchase
commented
- Added validation that no other fusor deployment is running.
- Added validation that deployment's hosts are not already managed.
- Added filter for engine/hypervisor discovered hosts to omit hosts associated with a currently running deployment.
| deployment.errors[:foreman_task_uuid] << _("Deployment #{other.id}: #{other.name} is already running") | ||
| end | ||
| end | ||
|
|
There was a problem hiding this comment.
ruby looks good. My biggest worry is we have to wait for one deployment to completely finish before being able to kick the other one off. The biggest issue I see with multiples running at the same time is manage_content failing. But if we truly only support one at a time, this is it.
|
PR title has a typo: 'FIlter' instead of 'Filter' |
cfchase
changed the title
|
fixed PR title |
| @@ -119,7 +124,7 @@ export default Ember.Controller.extend(NeedsDeploymentMixin, { | |||
| !trackedHostIds | |||
| .filter((hostId) => this.get('hypervisorModelIds').contains(hostId)) | |||
| .map((k) => vState.get(k)) | |||
| .reduce((lhs, rhs) => lhs && rhs); | |||
| .reduce((previousAreTrue, currentValue) => previousAreTrue && currentValue, true); | |||
There was a problem hiding this comment.
Better var names 👍 I was guilty of the lhs/rhs
cfchase
changed the title
Added validation that deployment's hosts are not already managed.
hosts associated with a currently running deployment.
cfchase
changed the title
|
I know you were concerned about the promises here, but I actually think it's pretty clean given what had to be done to get the hosts. Read okay to me. ACK ember |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.