Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed autodelete of OSP nodes. #1131

Merged
merged 1 commit into from
Aug 5, 2016
Merged

Removed autodelete of OSP nodes. #1131

merged 1 commit into from
Aug 5, 2016

Conversation

cfchase
Copy link
Contributor

@cfchase cfchase commented Aug 5, 2016

This allows users to see the problem nodes and associated information and error before manually deleting
them. There's no need to auto-delete nodes now that users can do it easily and it was preventing the associated errors from being displayed (if for instance the user entered in bad password info)

nodes and associated information and error before manually deleting
them.
@cfchase
Copy link
Contributor Author

cfchase commented Aug 5, 2016

@jmontleon I found where the node was being autodeleted. I removed the one in node_controller previously but not this one.

@coveralls
Copy link

coveralls commented Aug 5, 2016

Coverage Status

Coverage increased (+0.08%) to 71.11% when pulling b363d2c on cfchase:dont-delete-osp-node into 2cc6572 on fusor:master.

@eriknelson
Copy link
Contributor

ACK

@eriknelson eriknelson merged commit 276c5a7 into fusor:master Aug 5, 2016
@cfchase cfchase deleted the dont-delete-osp-node branch August 8, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants