Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type of BuildCache CreatedAt and LastUsedAt #89

Closed
mdonoughe opened this issue Jul 27, 2020 · 1 comment · Fixed by #90
Closed

fix type of BuildCache CreatedAt and LastUsedAt #89

mdonoughe opened this issue Jul 27, 2020 · 1 comment · Fixed by #90

Comments

@mdonoughe
Copy link
Contributor

I contributed some code to stepchowfun/docuum to use Bollard instead of invoking the Docker CLI, and almost immediately after releasing this version it was discovered that Bollard cannot parse the output of /system/df when if the user has been using BuildKit (stepchowfun/docuum#78).

Bollard is following exactly the Docker documentation, which was apparently wrong in this case (moby/moby#41264). The documentation was fixed in moby/moby#41267, but possibly the URL where Bollard pulls the API specifications from won't be updated until Docker 20.03 ships (I just checked and it hadn't been), and even then Bollard will need a rebuild because the generated code is in codegen/target/generated-sources/src/models.rs.

I don't know if you want to pick up the new spec from the repo now or if you want to wait until the spec is updated on the website. In the mean time, Docuum has gone back to using Docker CLI.

@fussybeaver
Copy link
Owner

Thanks for the detailed write-up and reporting this upstream.

I'm not against referencing the swagger YAML in a tag of moby's Github instead of the website, and regenerating the API stubs, though I'd want the tag somehow reflected in the versioning of the bollard-stubs repository. Perhaps, that could be done using an alpha release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants