Switch back to using the Docker CLI rather than the Docker API #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch back to using the Docker CLI rather than the Docker API.
This is needed to work around fussybeaver/bollard#113, and it's is motivated more generally by my desire to switch away from Bollard for the following reasons:
Docker::eventsnot receiving events from Docker? fussybeaver/bollard#113), and I don't have the time to debug these issues. I've already spent too much time dealing with issues related to this. (Bollard is a great project, but I am only willing to use battle-tested dependencies for high availability.)Unfortunately, there is one thing that was better about the Docker API: the image list RPC gave us the parent IDs of the images, whereas
docker image lsappears incapable of doing so. Since v0.13.0, Docuum needs this parent-child info in order to determine an effective order for deleting images based on the dependencies between them. This means Docker now has to query for the parent of each image individually, which is slow. I have implemented logic to cache this parent-child information so we can avoid recomputing it on every run, but that means this diff is unfortunately quite large.cc @mdonoughe @juliahw
Status: Ready
Fixes: N/A