-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minified JS broken with private class identifiers #393
Comments
Autoptimize uses Mr Clay's JS minify for the minification @PLUS-RobertEhrenleitner, it might make more sense to report it there. When solved there I can make sure the upstream update is "inherited" by AO as well. |
Thank you for this fast response, I reissued it there. |
This issue is fixed by the commit which updates JSMin including my fix. |
Thanks for the fixes Robert!
…On Wed, Dec 14, 2022 at 1:48 PM Robert Ehrenleitner @ PLUS < ***@***.***> wrote:
Closed #393 <#393> as
completed.
—
Reply to this email directly, view it on GitHub
<#393 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABMIMNEXYBE7RM4VEET3Y3WNG63HANCNFSM6AAAAAASKAO3JE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a class contains private attributes or methods, the necessary line break or semicolon is not inserted.
As a minimum non-working example, the following class in valid JavaScript syntax does not work:
It is minified to:
which contains several syntax errors: There should be line breaks or semicolons between all the attributes and methods.
The text was updated successfully, but these errors were encountered: