Static Analysis fixes

[szepeviktor]

@futtta You find the test tool here https://github.com/szepeviktor/autoptimize/commit/1644b182c11523c797b9fc507090bf4182fca083

[szepeviktor]

This is Level 0.
You are free to continue static analysis on higher levels!

TODOs for Level 1:

• add valid PHPDoc for all properties and methods
• add missing constants in test/phpstan-bootstrap.php

[szepeviktor]

Could you take a look at the CDN test?

[futtta]

hey @szepeviktor I just synced "master" with the 2.5 codebase (which i released earlier today), could you look into the conflict above? also the travis tests are failing, might be because you force a different wordpress version resulting in different hashes for the autoptimized files?

[szepeviktor]

might be because you force a different wordpress version resulting in different hashes for the autoptimized files

Okay, I've reviewed the 8 changes in this PR but I do not understand which is related to WP version. Could you help me?

[futtta]

"all checks have passed" and " no conflicts with the base branch, so that hurdle has been taken. i'll review more in detail tomorrow Viktor :-)

@zytzagoo in case you have time and you're interested feel free to chime in!

[szepeviktor]

@futtta Thank you for merging.

Are interested adding static analysis to TravisCI?

[futtta]

why not :)

…

On Tue, Apr 23, 2019 at 11:40 AM Viktor Szépe ***@***.***> wrote: @futtta <https://github.com/futtta> Thank you for merging. Are interested adding static analysis to TravisCI? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#246 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABMIMNN2AKYPMRWKKN4IQTPR3KRPANCNFSM4HHPYYYA> .