Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add fvuls image #1426

Merged
merged 1 commit into from
Mar 24, 2022
Merged

chore: add fvuls image #1426

merged 1 commit into from
Mar 24, 2022

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Mar 23, 2022

What did you implement:

When master and tag are pushed, a Docker image for FutureVuls is also created.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

manual build

$ docker build -t vuls/fvuls -f ./contrib/Dockerfile .
$ docker run -it --rm vuls/fvuls /bin/sh
/vuls # vuls -v
vuls v0.19.4 build-20220323_024728_a1cc152e
/vuls # trivy-to-vuls version
trivy-to-vuls-v0.19.4-build-20220323_024821_a1cc152e
/vuls # future-vuls version
future-vuls-v0.19.4-build-20220323_025131_a1cc152e

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Mar 23, 2022
@MaineK00n MaineK00n marked this pull request as draft March 23, 2022 19:45
@MaineK00n MaineK00n marked this pull request as ready for review March 23, 2022 23:06
Copy link
Member

@kotakanbe kotakanbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kotakanbe kotakanbe merged commit 04f246c into master Mar 24, 2022
@kotakanbe kotakanbe deleted the MaineK00n/add-fvuls-image branch March 24, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants