Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix updatalbe packages count #373 #374

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Fix updatalbe packages count #373 #374

merged 1 commit into from
Mar 7, 2017

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Mar 7, 2017 •
edited
Loading

What did you implement:

Closes #373

How did you implement it:

Don't count duplicate package names.

How can we verify it:

Make sure that the number of updatable packages of vuls scan result and yum check-update are the same

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@kotakanbe kotakanbe added the bug label Mar 7, 2017
@kotakanbe kotakanbe added this to the v0.3.0 milestone Mar 7, 2017
@kotakanbe kotakanbe merged commit 0058eaf into master Mar 7, 2017
@kotakanbe kotakanbe deleted the package-count branch March 16, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kotakanbe