Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Hostkey check #417

Merged
merged 3 commits into from Apr 6, 2017
Merged

SSH Hostkey check #417

merged 3 commits into from Apr 6, 2017

Conversation

kotakanbe
Copy link
Member

@kotakanbe kotakanbe commented Apr 4, 2017

What did you implement:

Closes #415

How did you implement it:

Change options of SSH command.

How can we verify it:

  1. Remove the entry of target server in $HOME/ssh/.known_hosts
  2. Vuls scan -> Error will be occurred because faild to connect via ssh
  3. SSH manually to add a host key to known_hosts
  4. Vuls scan -> success

[TODO] Fix README

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

@kotakanbe kotakanbe requested a review from knqyf263 April 4, 2017 15:30
@kotakanbe kotakanbe changed the title [WIP]Hostkey check [WIP]SSH Hostkey check Apr 4, 2017
@kotakanbe kotakanbe changed the title [WIP]SSH Hostkey check SSH Hostkey check Apr 5, 2017
Copy link
Contributor

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 knqyf263 merged commit e20a59b into master Apr 6, 2017
@knqyf263 knqyf263 deleted the hostkey-check branch April 6, 2017 09:09
lapthorn pushed a commit to lapthorn/vuls that referenced this pull request May 11, 2017
* Add Hostkey check as default behavior when SSH
@2solt
Copy link
Contributor

2solt commented May 22, 2018

Since the external ssh using the ~/.ssh/config, can we leave the StrictHostKeyChecking to the user to configure? Currently is baked in.

@kotakanbe
Copy link
Member Author

@2solt

How about adding an option like -ssh-no-strict-hostkey-checking?
(Please propose if you have a nice name :)

@2solt
Copy link
Contributor

2solt commented May 22, 2018

That's sounds good as well!
I was just thinking whoever needs to set it could add:

Host *
    StrictHostKeyChecking yes

to ~/.ssh/config or /etc/ssh/ssh_config

(Im not particularly good with naming things :)

@choseh
Copy link

choseh commented May 30, 2018

Any news here? We're building a deployment for vuls on Kubernetes with helm and this is breaking everything. Could you come up with a quick solution? Command-line options take precedence over configuration files, so there's no way to work around this right now.

@kotakanbe
Copy link
Member Author

@choseh

I will do it tomorrow 👍

kotakanbe added a commit that referenced this pull request May 31, 2018
kotakanbe added a commit that referenced this pull request May 31, 2018
@kotakanbe
Copy link
Member Author

@2solt @choseh

merged 👍
#660

@kotakanbe
Copy link
Member Author

@choseh

Would you write a blog on usage examples at k8s?

kotakanbe added a commit that referenced this pull request May 31, 2018
* master:
  feat(scan): add -ssh-config option #417 (#660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants