Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Suggest that the browser automatically redirects to the paper webpage when clicking on the publication place #469

Closed
yym68686 opened this issue Apr 1, 2024 · 7 comments · Fixed by #475
Assignees
Labels
feature-request New feature request

Comments

@yym68686
Copy link

yym68686 commented Apr 1, 2024

Suggest that the browser automatically redirects to the paper webpage when clicking on the publication place

image
@yym68686 yym68686 added the feature-request New feature request label Apr 1, 2024
@GeoffreyChen777
Copy link
Member

For papers with arxiv id and doi, it's easy to achieve this. Is it enough?

For papers without such an identifier, it's hard.

@yym68686
Copy link
Author

yym68686 commented Apr 1, 2024

This software is really excellent. I know that I can find papers through arXiv ID and DOI. I need to first open the paper details panel, then copy the arXiv ID and DOI, then open the browser, and search for the paper through the arXiv ID and DOI number, which will be more troublesome for me.

Every time I want to reread a paper and see that the publication is listed as arXiv, I unconsciously click on arXiv, but actually, nothing happens. This is very frustrating for me. I think being able to click on the publisher to directly reach the paper's page is very intuitive and user-friendly. I hope this feature can be added.

@GeoffreyChen777
Copy link
Member

I mean, we can add this feature. But only for papers with arxivID and DOI. With such an identifier, it would be easy to infer their online source URL.

For papers without such an identifier, we cannot.

@yym68686
Copy link
Author

yym68686 commented Apr 1, 2024

Thank you, since most of the new papers I need to read are on arXiv, this is already enough for me. Really looking forward to such new features!

@charlieJ107
Copy link
Member

Just a catch up if there's not yet assigned to someone else, I'll take this task and implement this feature. @GeoffreyChen777

@GeoffreyChen777
Copy link
Member

@charlieJ107 sure, thanks!

GeoffreyChen777 added a commit that referenced this issue Apr 5, 2024
This PR implemented #469 

I added two link button that open the system default external browser to
open the arxiv or doi link based on the `arxiv` and `doi` properties in
`PaperEntity`. These two buttons only shows when these two properties
existed.

I also remove the `formatOnSave` settings in `.vscode/settings.json`
because the format behaviour may vary on different platform, which may
mess up the format of entire file.

---------

Co-authored-by: geoffreychen777 <geoffreychen777@gmail.com>
@GeoffreyChen777
Copy link
Member

implemented. Please wait for the next release.

Now we have a new section called 'Online Resources' in the details panel. It looks like this:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants