-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add links to webpage for papers with arxiv and doi #475
[Feature] Add links to webpage for papers with arxiv and doi #475
Conversation
7f74b40
to
93ed99f
Compare
93ed99f
to
e731b75
Compare
It looks good. I’m thinking what about merging this with the source code section to get a section called ‘online resource’? |
Should it be in the same slot with the publisher (slot 1) or at the bottom of the paper details (slot 3)? |
We leave the publication text in the publication section. And we move the link buttons, such as the ‘DOI’ one in the screenshot to the source code section and we rename the source code section to ‘online resource’ section. |
Looks good.👍🏻 thanks. I will review the code once I back from my trip. |
I fixed some bugs 9b6c02f , now everything looks good to me. |
This PR implemented #469
I added two link button that open the system default external browser to open the arxiv or doi link based on the
arxiv
anddoi
properties inPaperEntity
. These two buttons only shows when these two properties existed.I also remove the
formatOnSave
settings in.vscode/settings.json
because the format behaviour may vary on different platform, which may mess up the format of entire file.