Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add links to webpage for papers with arxiv and doi #475

Conversation

charlieJ107
Copy link
Member

@charlieJ107 charlieJ107 commented Apr 5, 2024

This PR implemented #469

I added two link button that open the system default external browser to open the arxiv or doi link based on the arxiv and doi properties in PaperEntity. These two buttons only shows when these two properties existed.

I also remove the formatOnSave settings in .vscode/settings.json because the format behaviour may vary on different platform, which may mess up the format of entire file.

@charlieJ107 charlieJ107 added enhancement Enhancement mid-priority mid priority labels Apr 5, 2024
@charlieJ107 charlieJ107 self-assigned this Apr 5, 2024
@charlieJ107 charlieJ107 force-pushed the features/469-browser-automatically-redirects-to-the-paper-webpage-when-clicking-on-the-publication-place branch from 7f74b40 to 93ed99f Compare April 5, 2024 11:01
@charlieJ107 charlieJ107 force-pushed the features/469-browser-automatically-redirects-to-the-paper-webpage-when-clicking-on-the-publication-place branch from 93ed99f to e731b75 Compare April 5, 2024 11:01
@charlieJ107 charlieJ107 marked this pull request as ready for review April 5, 2024 11:21
@charlieJ107
Copy link
Member Author

charlieJ107 commented Apr 5, 2024

FYI, here're some screenshots:

image

image

@GeoffreyChen777
Copy link
Member

It looks good. I’m thinking what about merging this with the source code section to get a section called ‘online resource’?

@charlieJ107
Copy link
Member Author

It looks good. I’m thinking what about merging this with the source code section to get a section called ‘online resource’?

Should it be in the same slot with the publisher (slot 1) or at the bottom of the paper details (slot 3)?

@GeoffreyChen777
Copy link
Member

We leave the publication text in the publication section. And we move the link buttons, such as the ‘DOI’ one in the screenshot to the source code section and we rename the source code section to ‘online resource’ section.

@charlieJ107
Copy link
Member Author

Now it's like this:

image

@GeoffreyChen777
Copy link
Member

Looks good.👍🏻 thanks.

I will review the code once I back from my trip.

@GeoffreyChen777
Copy link
Member

I fixed some bugs 9b6c02f , now everything looks good to me.

@GeoffreyChen777 GeoffreyChen777 merged commit 0b8e429 into main Apr 5, 2024
@GeoffreyChen777 GeoffreyChen777 deleted the features/469-browser-automatically-redirects-to-the-paper-webpage-when-clicking-on-the-publication-place branch April 6, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement mid-priority mid priority
Projects
Status: Done
2 participants