Tidy up code #33
Tidy up code #33
Conversation
Fix for issue #29 (timer roll-over displaying 58:47)
|
@bonzer35 Isn't this change already in main? Why does it need merged back to |
|
You requested some remnants of zeros and ones to be removed and replaced by
true/false, so I did that.
…On Tue, 6 Jun 2023, 1:06 pm Kevin Balthaser, ***@***.***> wrote:
Isn't this change already in main? Why does it need merged back to
sounder_for_review?
—
Reply to this email directly, view it on GitHub
<#33 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQRGO2ZJTT6BOWUIL6TEJSDXJ4ML7ANCNFSM6AAAAAAYZQU47E>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@bonzer35 Take a look at the changes listed in this PR, thats not what is in here, this contains your timer bug fix, and nothing else |
|
Ok, will take a look later
From: Kevin Balthaser ***@***.***>
Sent: 06 June 2023 13:54
To: futurexdesign/KiwiBoardFirmware ***@***.***>
Cc: bonzer35 ***@***.***>; Mention ***@***.***>
Subject: Re: [futurexdesign/KiwiBoardFirmware] Tidy up code (PR #33)
@bonzer35 <https://github.com/bonzer35> Take a look at the changes listed in this PR, thats not what is in here, this contains your timer bug fix, and nothing else
—
Reply to this email directly, view it on GitHub <#33 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQRGO222XTJSKPQD6LNIVBTXJ4R6RANCNFSM6AAAAAAYZQU47E> .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
That's strange. commit 3bd5f19 contains the removal of zeros and ones and this one shows the UI fix, but the UI fix should be in its own branch, not 'sounder_for_review'. When I checkout my local sounder_for_review, the UI changes have not been done in MotorControl, which is what I would expect. And where is UI_fix in the branch list? I'm confused. |
|
The UI Fix was merged previously. It doesn't need to be merged into the sounder branch, as it already exists in main. 3bd5f19 already exists in your branch |
Removed 0's and 1's