Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase Authentication Blocked by Fork #71

Closed
ghost opened this issue Jul 6, 2016 · 4 comments
Closed

Firebase Authentication Blocked by Fork #71

ghost opened this issue Jul 6, 2016 · 4 comments

Comments

@ghost
Copy link

ghost commented Jul 6, 2016

First off, loving the kit so far. I noticed it forks react-native-lock and is currently 56 commits behind auth0:master. I'm already feeling the pain as the fork has a bug preventing use of Auth0 delegation to the Firebase API, which was fixed in the upstream master and released to NPM.

Are there any immediate plans to update the fork or (ideally) stop forking?
@jevakallio
Copy link
Contributor

Yes, let's get the fork up to date!

As long as the lock component doesn't support UI customization we intend to keep forking this repo.

@jevakallio jevakallio mentioned this issue Jul 8, 2016
Closed
@ghost ghost mentioned this issue Jul 8, 2016
Closed
@jevakallio
Copy link
Contributor

I've rebased the https://github.com/futurice/react-native-lock/tree/feature/customizedTheme branch from upstream master.

@jhabdas could you re-run npm install in your app and verify that everything still works for you? It does for me.

@ghost
Copy link
Author

ghost commented Jul 8, 2016

On it

@ghost
Copy link
Author

ghost commented Jul 8, 2016

LGTM. Thanks for the update!

@ghost ghost closed this as completed Jul 8, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jevakallio