New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react-native-vector-icons #156
Conversation
@@ -1,3 +1,3 @@ | |||
PODFILE CHECKSUM: cb3339de6360cad344c46bd08cc9861e861af500 | |||
|
|||
COCOAPODS: 1.1.1 | |||
COCOAPODS: 1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not downgrade cocoapods here ;)
Thanks for the PR @lapanti :) 🚀 Will check it tomorrow |
@@ -1,6 +1,7 @@ | |||
package com.pepperoniapptemplate; | |||
|
|||
import com.facebook.react.ReactActivity; | |||
import com.oblador.vectoricons.VectorIconsPackage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this import needs to go in the MainApplication.java
and this
new VectorIconsPackage()
needs to be added inside the list of packages
@lapanti, I found the problem for your failing tests. You need to set the version for
|
@lapanti You can now rebase on master where we set now "jest-react-native": "~17.0.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now and works on both iOS and Android 👍
Related issue: #40