Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-native-vector-icons #156

Merged
merged 3 commits into from Dec 7, 2016
Merged

Add react-native-vector-icons #156

merged 3 commits into from Dec 7, 2016

Conversation

lapanti
Copy link
Contributor

@lapanti lapanti commented Nov 29, 2016

Related issue: #40

@@ -1,3 +1,3 @@
PODFILE CHECKSUM: cb3339de6360cad344c46bd08cc9861e861af500

COCOAPODS: 1.1.1
COCOAPODS: 1.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not downgrade cocoapods here ;)

@tino-junge
Copy link
Contributor

Thanks for the PR @lapanti :) 🚀 Will check it tomorrow

@@ -1,6 +1,7 @@
package com.pepperoniapptemplate;

import com.facebook.react.ReactActivity;
import com.oblador.vectoricons.VectorIconsPackage;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this import needs to go in the MainApplication.java and this

new VectorIconsPackage()

needs to be added inside the list of packages

@tino-junge
Copy link
Contributor

tino-junge commented Nov 30, 2016

@lapanti, I found the problem for your failing tests. You need to set the version for jest-react-native to 17.0 since 17.1 relies on react-native 38 but we are still on 37. To remove also the whatwg-fetch warning you could include it as well as devDependency:

package.json

...

"jest-react-native": "~17.0.2",
"whatwg-fetch": "~2.0.0"

@tino-junge
Copy link
Contributor

@lapanti You can now rebase on master where we set now "jest-react-native": "~17.0.2"

Copy link
Contributor

@tino-junge tino-junge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now and works on both iOS and Android 👍

@tino-junge tino-junge merged commit 283fef6 into futurice:master Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants