Refactor Navigation (see #51) #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomoscon
force-pushed
the
refactor-nav-exp
branch
2 times, most recently
from
8bb15c6
to
64da2b1
Compare
| const currentTab = navigationState.getIn(['routes', navigationState.get('index')]); | ||
| const tabs = navigationState.get('tabs'); | ||
| const tabKey = tabs.getIn(['routes', tabs.get('index')]).get('key'); | ||
| const currentTab = navigationState.get(tabKey); | ||
|
|
There was a problem hiding this comment.
changed the way to find currentTab accordingly to the navigationState changes
- use NavigationExperimental Card Stack - simplify navigationState separating tabs reducer from scene reducer - simplify navigation views - handle Android back button - remove unnecessary import of AppRouter - fixes futurice#85
fabriziomoscon
force-pushed
the
refactor-nav-exp
branch
from
64da2b1
to
8a1a764
Compare
| @@ -50,7 +49,7 @@ const AppView = React.createClass({ | |||
|
|
|||
| return ( | |||
| <View style={{flex: 1}}> | |||
| <NavigationViewContainer router={AppRouter} /> | |||
|
+1 Approve cool, want to use this one. |
|
@fabriziomoscon just got through a first pass review on this, awesome job! 💯 🍻 This is a lot cleaner and more future-proof that our previous solution! There are a couple of tiny fixes I'll need to make to merge this:
I want to get this merged ASAP, so I'll just cherry pick your changes to a new branch, fix and test these, and push it up. |
|
thanks. If you prefer I can fix those 2 point and repush |
|
I just merged this to master 🎉 Thanks @fabriziomoscon, hit me up sometime and I'll buy you a beer! |
This was referenced Aug 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by:
https://github.com/facebook/react-native/blob/master/Examples/UIExplorer/js/NavigationExperimental/NavigationCardStack-NavigationHeader-Tabs-example.js
and other example online
tested on Android on physical device
not tested on ios because of #77