Fix height handling #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least since Emacs 27.2, image-set-window-vscroll specifies VSCROLL in pixels, not lines.
|
Out of curiosity: do you have a pdf and note where this happens? I've never experienced this, and wanted to make sure I understood before adding your changes to my fork of the repo. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, the height parameter of org-pdftools link seems to be treated incorrectly:
C-c C-ojumps to a point that's way too high (i.e. way too close to the top of the page). There's code inorg-pdftools-open-pdftoolsthat converts the height (given as a fraction of page height) to number of lines before giving it toimage-set-window-vscroll, butimage-set-window-vscrollwants the input specified in pixels, not lines. This PR removes the conversion to lines.