Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPD-219] [BUG] matcha.state file to be updated on destroy #121 #124

Merged
merged 4 commits into from
May 26, 2023
Merged

[RPD-219] [BUG] matcha.state file to be updated on destroy #121 #124

merged 4 commits into from
May 26, 2023

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented May 25, 2023 •
edited
Loading

This PR:

  1. When matcha destroy is run matcha.state file is updated with the remaining resources.
  2. When matcha destroy full is run matcha.state is removed completely
  3. Updated the way that matcha.satate is created and updated, it now uses terraform output variables

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@Christopher-Norman Christopher-Norman self-assigned this May 25, 2023
@Christopher-Norman Christopher-Norman added the bug Something isn't working label May 25, 2023
osw282
osw282 reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@osw282 osw282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! 🚀

tests/test_templates/test_run_azure_template.py Outdated Show resolved Hide resolved
osw282
osw282 approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@osw282 osw282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test, LGTM! 🔥

@Christopher-Norman Christopher-Norman merged commit 11855ad into develop May 26, 2023
@Christopher-Norman Christopher-Norman deleted the RPD-219-update-state-on-matcha-destroy-new branch May 26, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudeperf3ct dudeperf3ct dudeperf3ct approved these changes

@osw282 osw282 osw282 approved these changes

Assignees

@Christopher-Norman Christopher-Norman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christopher-Norman @dudeperf3ct @osw282