Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPD-215] [BUG] matcha provision fails running multiple times #129

Merged
merged 16 commits into from
May 30, 2023
Merged

[RPD-215] [BUG] matcha provision fails running multiple times #129

merged 16 commits into from
May 30, 2023

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented May 26, 2023 •
edited
Loading

This PR adds a check for a resource group to the remote state manager to prevent a ResourceGroupNotFound error from Azure.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@Christopher-Norman Christopher-Norman self-assigned this May 26, 2023
@Christopher-Norman Christopher-Norman added the bug Something isn't working label May 26, 2023
JonoCX
JonoCX requested changes May 30, 2023
View reviewed changes
Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🦾 See comment

src/matcha_ml/services/azure_service.py Outdated Show resolved Hide resolved
dudeperf3ct
dudeperf3ct approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@dudeperf3ct dudeperf3ct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done @Christopher-Norman

src/matcha_ml/services/azure_service.py Outdated Show resolved Hide resolved
JonoCX
JonoCX reviewed May 30, 2023
View reviewed changes
src/matcha_ml/services/azure_service.py
"""
rg_state = self.resource_group_state(resource_group_name)

return isinstance(rg_state, ProvisionState)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this solution - nice!

JonoCX
JonoCX approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦾

@Christopher-Norman Christopher-Norman merged commit 60f08c7 into develop May 30, 2023
@Christopher-Norman Christopher-Norman deleted the RPD-215-fix-provision branch May 30, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonoCX JonoCX JonoCX approved these changes

@dudeperf3ct dudeperf3ct dudeperf3ct approved these changes

Assignees

@Christopher-Norman Christopher-Norman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christopher-Norman @JonoCX @dudeperf3ct