[RPD-278] Bug Fixes and Improvements #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* various changes * change variable names to make things more clear * shubham's comment * test for latest * update existing tests * update existing tests * shubham latest comment * add gitflow notation branches to ci (#183) * remove old, commented out code
* adds logic and tests for matcha config module * updates docstrings * adds tests and implements config object throughout matcha * updated for pr comments * updates docstring * fixes ci * updates for comments
…#181) * refactor analytics service * adds tests and updates for comments * updates tests * updates for comments * extracts _get_state_uuid logic into private function * removes old _get_state_uuid logic * updates _execute_analytics_event_function * extracts _time_event logic * adds _post_event logic * adds tests * adds dataclass * updates tests
* updates core and azure_runner * adds test * updated for comments * updates test fixtures
…_state.py` to use objects defined within matcha_state.py (#190) * updates build_state_from_terraform_outputs * updates for comments * fixes tests * removes print statement * updates get_component * updates get_component * updates for comments
…ching property/component is not found (#192)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of bugs and improves the code base:
matcha.config.jsonfile. #184analytics_serviceto simplify tracking decorator #181_show_terraform_outputs()intoprovision#188build_state_from_terraform_outputwithinmatcha_state.pyto use objects defined within matcha_state.py #190Checklist
Please ensure you have done the following:
Type of change
Tick all those that apply: