Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Preinstall fails when vnstat version has higher major but lower Minor (like 2.6) #11

Open
yajouahr opened this issue Oct 13, 2020 · 2 comments
Labels

Comments

@yajouahr
Copy link

in preinstall script, your check if version is higher or equal to 1.13 fails for version 2.6 for example.

if( major === 1 && minor >= 13 || major > 1) return;

should work better.
I had to dowgrade my vnstat version so that it works.

@fvdm
Copy link
Owner

fvdm commented Oct 13, 2020

@yajouahr Thanks! The code of this pkg looks super old. I'm rewriting it today.

@fvdm fvdm added the bug label Oct 14, 2020
fvdm added a commit that referenced this issue Oct 15, 2020
@7c
Copy link

7c commented Aug 13, 2021

have you updated the npm? So we can do an update please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants