Optional Skulls UX. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Skulls interaction elements now display as solid circles when full, and "x"-circles when damaged. - Fixed items not displaying red skulls when broken.
jimorie
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
To be honest I'm not a huge fan of the solid circles. For me this is a step away from how I use the physical character sheet.
But I guess this comes down to personal preference, and I'm not heavily against or anything. Maybe you could get a second opinion, otherwise go with it! 👍
|
Yeah this is a very opinionated change. I'm still listing it as a draft as I was thinking of making it an option instead. Would require rewriting a bit of the logic for willpower. Will work on it a bit more, but not for Sunday's release. |
aMediocreDad
added this to To be Reviewed
in Forbidden Lands Development
via automation
aMediocreDad
moved this from To be Reviewed
to Devs are working on
in Forbidden Lands Development
aMediocreDad
commented
Feb 25, 2021
aMediocreDad
moved this from Devs are working on
to Being reviewed
in Forbidden Lands Development
Closed
13 tasks
aMediocreDad
force-pushed
the
skulls-cleanup
branch
from
eba2b8b
to
6c7b1d4
Compare
|
I have tested this thoroughly at this point, and have encountered no issues so far. Merging. |
aMediocreDad
added a commit
to aMediocreDad/forbidden-lands-foundry-vtt
that referenced
this pull request
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incidentally also fixes an issue where broken items bonus didn't display red.