Add weapon features' toggles and integrate features with chat and combat actions #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the weapon features from a single string to an object containing all features available in the core rules. * melee weapon features: edged, pointed, blunt, parrying and hook * ranged weapon feature: slow reload A free-form list is left to allow custom features to be added to weapons. The weapon sheet was modified to let users select the weapon features via toggles. Available toggles depend on the current weapon's category (melee or ranged). There are also some changes in the way weapons are posted to the chat, mostly to allow the localization of stock weapon features.
As stated by combat rules: "If you PARRY with a weapon that lacks the PARRYING feature, you get a -2 penalty." The parry action link in the combat tab will display the penalty if a melee weapon lacks the appropriate feature.
Weapon features are now objects instead of a string. The migration was kept simple: the previous value is moved over to the "others" field (which as free-form string).
giant-teapot
added this to To be Reviewed
in Forbidden Lands Development
via automation
|
Great! I'm looking forward to checking it out:) Will hopefully get to it tomorrow. |
aMediocreDad
requested changes
Mar 2, 2021
aMediocreDad
moved this from To be Reviewed
to Being reviewed
in Forbidden Lands Development
Closed
13 tasks
- The migration changes are compatible with the official content and likely other English worlds. - WorldSchema is now an integer and failsafes are built in for schemaVersions larger than system version.
aMediocreDad
approved these changes
Mar 10, 2021
aMediocreDad
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
I have taken care of the changes I requested, and have reviewed the changes using the official modules, as well as I can. Will go ahead and merge and close this one.
Great addition to the system! Thanks @giant-teapot ⭐
|
Ah, I finally got a moment to myself and as I was about to work on those final touches and I just saw you already took care of it! |
giant-teapot
added a commit
to giant-teapot/forbidden-lands-foundry-vtt
that referenced
this pull request
Mar 13, 2021
Fixes a small UI bug introduced with fvtt-fria-ligan#47: only weapon's additional ("others") features would appear in the character sheet's combat tab. This fix reverts back to the old behaviour as all weapon features should appear for each eligible items.
aMediocreDad
added a commit
to aMediocreDad/forbidden-lands-foundry-vtt
that referenced
this pull request
Apr 7, 2021
aMediocreDad
pushed a commit
to aMediocreDad/forbidden-lands-foundry-vtt
that referenced
this pull request
Apr 7, 2021
Fixes a small UI bug introduced with fvtt-fria-ligan#47: only weapon's additional ("others") features would appear in the character sheet's combat tab. This fix reverts back to the old behaviour as all weapon features should appear for each eligible items.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't get as much time as I wanted to work on this, but finally: here it is. You can now specify weapon features in a way that is easier for the system to understand.
The bulk of the change can be summarized by the datamodel change:
The rest is just making it visible and having a few quality of life improvements. So what do we have in stock?
features->features.others.And that's about it. Tell me what you think about this! :)
Addresses #19