-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FvwmButtons on FVWM3 #28
Comments
Hi, I've heard of this. How is the geometry of FvwmButtons being specified? Can you dig around the configuration? I suspect it's a relative geometry, in which case I'll have to take the origin output into consideration. |
This is the only line on my cfg that is related to Geometry. *FvwmButtons: Geometry -0+0 |
I'm testing on a RPI4 using Arch and think I can add info here. Buttons are called with "*RightPanel: Geometry 120x$[vp.height]-0+0" Same one-physical-screen-issue here, then the buttons are not displayed at all. When I have two physical screens attached, the buttons are displayed on my primary screen as expected, but not placed on its right margin, but "somewhere in the middle". This "somewhere in the middle", however, would be exactly the right margin of my smaller secondary screen. Workaround for now: I've changed "-0+0" into "+0+0" and have my RightPanel fixed to the left margin of my primary screen. Setup using xrandr, no xorg-conf or xinerama as far as I can tell (which means: at least not consciously switched on). |
I hope the pictures can show in how far the ta/gh-22 branch miscalculates the hight of the screen. |
Yes. That happens when you use two monitors with fvwm3. But I think this issue is actually related to #22, hence why it also affects the logout window. But I may be mistaken. |
Hi, @lgsobalvarro and @MasterP-theGu -- I've just pushed a new fix for #22, can you test that to see if those changes also fix this problem? Thanks! |
Hi @ThomasAdam No. The problem still persists at least for me. However I did notice a change.
|
Sorry, I only came to my study now. Built the new #22 and ran it with a clean config. FvwmIdent returns the actual placement of the panel. In my modified config, I start the panel with When I start the new build of #22 with its default config, the config (which misplaces the Buttons) says: (I tried to figure out the vertical equivalent of vp.height, but to no avail, so I can't test that.) |
So... FvwmButtons in this case will start up on whichever screen has the mouse pointer, since that's how the calculation is performed. Either way, I'm still finding FvwmButtons being placed on either right edge of the screen, and not in the middle of the screen, per your screenshots. |
I think the issue is related to the fact that both screens have different resolutions. In my case: Posisbly fvwm/randr or whatever is assuming both screens have the same resolution (1920x1080) so, that's why FvwmButtons is misplaced. Update: |
I know it's silly to just repeat what someone else has already said or written, but it might make sense to confirm Igsobalvarro's obvervation. No matter which one is the primary screen, xrandr (like the console) takes the smallest / most narrow resolution to define where "+0+0" is. UPDATE: Once
|
When parsing geometry strings, ensure the "global" screen is taken in to account. Prior to this, the individual monitor was assumed. This should fix GH issue #28.
When parsing geometry strings, ensure the "global" screen is taken in to account. Prior to this, the individual monitor was assumed. This should fix GH issue #28.
Hi all, Please can those of you who were running in to this problem compile FVWM3 from the How, with the specified FvwmButtons geometry, the panel is always placed on the furthest right monitor configured. Thanks! |
The ta/gh-28 works for me. My FvwmButtons Front Panel on restart ends up on the bottom center where it belongs. This was not the case past days, while we were testing other things. |
When parsing geometry strings, ensure the "global" screen is taken in to account. Prior to this, the individual monitor was assumed. This should fix GH issue #28.
When parsing geometry strings, ensure the "global" screen is taken in to account. Prior to this, the individual monitor was assumed. This should fix GH issue #28.
All, I've closed this for now, as it appears to be working well for me. But please do reopen this issue if it's still not fixed. Note that in |
Hi @ThomasAdam Sadly is not working quite well for me. FvwmButtons is being placed in the secondary screen (1920x1080), not in the primary (1366x768). In addition FvwmButtons placement responds to the primary screen, not the secondary. A similar issue occurs if I set the secondary as primary. Maybe I'm missing something on my configuration, that tells Fvwm to place Buttons on the primary screen. It may be user error. If there is any other additional information that could be fo help to you, pelase let me know. |
That's because in
It's not a user error, no. Just an omission. I'll fix this.
Other than not using the primary screen, I presume the placement is now consistent across monitors (i.e., isn't in the middle or off to one side, as in @MasterP-theGu's screenshots?) Thanks, |
It is, well... kind of... If I set both screens to use the same resolution (1280x720) it works perfectly, and is placed on my primary screen in the correct place. |
When working out where to place windows, ensure we make use of the primary monitor. This can be accessed via the $[monitor.primary] variable. For example: Style * StartsOnScreen $$[monitor.primary] Helps fix GH issue #28
Hello again everyone, Thanks, @lgsobalvarro. I don't think there should be an issue with different sized monitors as that's what I'm using for testing. I've pushed 9707b2b to |
That did the trick. FvwmButtons is now being place correctly on my 2nd monitor. |
OK. Cool. Would you say this is now in a mergeable state? |
Seems so. I'll play with it more next week. Let's see to if it works well enough for @MasterP-theGu too. |
Yes, it works fine on this side of the channel, too. |
The RightPanel is placed on the rightmost edge of my primary screen, and with my config (*RightPanel: Geometry 120x$[vp.height]+0+0) it stays on the leftmost edge of my primary screen after reboot, even if I reboot from secondary screen; before the most recent changes, a restart from the second screen had moved the panel to the left of the second screen, so that's definitely a thumbs-up. |
Thanks everyone. Will merge to master. |
When working out where to place windows, ensure we make use of the primary monitor. This can be accessed via the $[monitor.primary] variable. For example: Style * StartsOnScreen $$[monitor.primary] Helps fix GH issue #28
When parsing geometry strings, ensure the "global" screen is taken in to account. Prior to this, the individual monitor was assumed. This should fix GH issue fvwmorg#28.
When working out where to place windows, ensure we make use of the primary monitor. This can be accessed via the $[monitor.primary] variable. For example: Style * StartsOnScreen $$[monitor.primary] Helps fix GH issue fvwmorg#28
If using only one monitor FvwmButtons is never placed, even if it's loaded manually via FvwmConsole. This issue is persistent with the default config and my custom. xsession-errors does not show anything unusual with FvwmButtons.
If using two monitors FvwmButtons is placed in the second screen, but FvwmButtons is not placed where it's supposed to be. Once again, this occurs with the default, and my custom config.
Tested on OpenSUSE Tumbleweed. FVWM was built without Rplay support.
The text was updated successfully, but these errors were encountered: