New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fvwm3 segfaults on xterm with short lifetime #785
Comments
When identifying windows via XQueryTree(), ensure that both children and nchildren are considered. Fixes #785 Signed-off-by: Thomas Adam <thomas@fvwm.org>
When identifying windows via XQueryTree(), ensure that both children and nchildren are considered. Fixes #785 Signed-off-by: Thomas Adam <thomas@fvwm.org>
Thanks. Can you please check the |
@ThomasAdam Thanks for the quick fix. And yes, your commit indeed fixes the issue. Just one minor nitpick, not sure whether this worries you: When running the test case, Fvwm succeeds to draw the window placement frame (just to discard it when it gets placed) in approx. 1 of 5 tries, in all other cases nothing at all happens. So something races there ... |
When identifying windows via XQueryTree(), ensure that both children and nchildren are considered. Fixes #785 Signed-off-by: Thomas Adam <thomas@fvwm.org>
@farblos -- that will have always been the case. |
Upfront Information
fvwm3 --version
)uname -sp
)Expected Behaviour
Executing
xterm -e true
does not crash Fvwm3.Actual Behaviour
Executing
xterm -e true
crashes Fvwm3 rather frequently (4 out of 5 times).Enabling logging
fvwm logging goes to the journal on my system. The relevant excerpt is:
Steps to Reproduce
Execute below test case with following minimal
.fvwm/config
:In the test window, execute
xterm -e true
until Fvwm3 crashes.Does Fvwm3 crash?
Yes:
Full:
The text was updated successfully, but these errors were encountered: