FvwmPager make mini windows always round down.

[somiaj]

When computing the size of the mini windows, there was a bug
where the bottom edge of a window could extend one pixel beyond
the pager's bottom edge. This was due to the rectangle that stored
the size of the pager's window being adjusted to be a multiple
of the number of visible pages, but not also adjusting the actual
pager's window size. Thus the math was computing the desk size
(and then the window size) was based on an incorrect window size
causing a miscalculation. The code that did this was an artifact
left behind when removing the sizehints. As a result the function
adjust_for_sizehints is no longer needed, and was removed fixing
the problem.

In addition, when ReConfiguring the pager, the background was
unnecessary being redrawn twice for Transparent colorsets, so
removed that as well.

This replaces #679, and fixes the issue it was trying to fix.

@topcat001 Can you double check that this fixes the issue for you, my tests seem positive so far.

[topcat001]

This looks great! I’ll build it soon and report back, thank you!

…

________________________________ From: Jaimos Skriletz ***@***.***> Sent: Wednesday, November 9, 2022 9:04:53 PM To: fvwmorg/fvwm3 ***@***.***> Cc: Anindya Mukherjee ***@***.***>; Mention ***@***.***> Subject: [fvwmorg/fvwm3] FvwmPager make mini windows always round down. (PR #756) When computing the size of the mini windows, there was a bug where the bottom edge of a window could extend one pixel beyond the pager's bottom edge. This was due to the rectangle that stored the size of the pager's window being adjusted to be a multiple of the number of visible pages, but not also adjusting the actual pager's window size. Thus the math was computing the desk size (and then the window size) was based on an incorrect window size causing a miscalculation. The code that did this was an artifact left behind when removing the sizehints. As a result the function adjust_for_sizehints is no longer needed, and was removed fixing the problem. In addition, when ReConfiguring the pager, the background was unnecessary being redrawn twice for Transparent colorsets, so removed that as well. This replaces #679<#679>, and fixes the issue it was trying to fix. @topcat001<https://github.com/topcat001> Can you double check that this fixes the issue for you, my tests seem positive so far.

________________________________ You can view, comment on, or merge this pull request online at: #756 Commit Summary * e0e1024<e0e1024> FvwmPager make mini windows always round down. File Changes (1 file<https://github.com/fvwmorg/fvwm3/pull/756/files>) * M modules/FvwmPager/x_pager.c<https://github.com/fvwmorg/fvwm3/pull/756/files#diff-59c16517f49a0d9f3af04f23504c9532e5fdfa119042823f0fea95bded7aab63> (52) Patch Links: * https://github.com/fvwmorg/fvwm3/pull/756.patch * https://github.com/fvwmorg/fvwm3/pull/756.diff — Reply to this email directly, view it on GitHub<#756>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFLGE6UUX7RMHKTDACUZFC3WHR67LANCNFSM6AAAAAAR4E44Q4>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[topcat001]

Just did a quick test and looks good on my setup, thanks!

…

________________________________ From: Anindya Mukherjee ***@***.***> Sent: Wednesday, November 9, 2022 10:10:08 PM To: fvwmorg/fvwm3 ***@***.***>; fvwmorg/fvwm3 ***@***.***> Cc: Mention ***@***.***> Subject: Re: [fvwmorg/fvwm3] FvwmPager make mini windows always round down. (PR #756) This looks great! I’ll build it soon and report back, thank you!

________________________________ From: Jaimos Skriletz ***@***.***> Sent: Wednesday, November 9, 2022 9:04:53 PM To: fvwmorg/fvwm3 ***@***.***> Cc: Anindya Mukherjee ***@***.***>; Mention ***@***.***> Subject: [fvwmorg/fvwm3] FvwmPager make mini windows always round down. (PR #756) When computing the size of the mini windows, there was a bug where the bottom edge of a window could extend one pixel beyond the pager's bottom edge. This was due to the rectangle that stored the size of the pager's window being adjusted to be a multiple of the number of visible pages, but not also adjusting the actual pager's window size. Thus the math was computing the desk size (and then the window size) was based on an incorrect window size causing a miscalculation. The code that did this was an artifact left behind when removing the sizehints. As a result the function adjust_for_sizehints is no longer needed, and was removed fixing the problem. In addition, when ReConfiguring the pager, the background was unnecessary being redrawn twice for Transparent colorsets, so removed that as well. This replaces #679<#679>, and fixes the issue it was trying to fix. @topcat001<https://github.com/topcat001> Can you double check that this fixes the issue for you, my tests seem positive so far.

________________________________ You can view, comment on, or merge this pull request online at: #756 Commit Summary * e0e1024<e0e1024> FvwmPager make mini windows always round down. File Changes (1 file<https://github.com/fvwmorg/fvwm3/pull/756/files>) * M modules/FvwmPager/x_pager.c<https://github.com/fvwmorg/fvwm3/pull/756/files#diff-59c16517f49a0d9f3af04f23504c9532e5fdfa119042823f0fea95bded7aab63> (52) Patch Links: * https://github.com/fvwmorg/fvwm3/pull/756.patch * https://github.com/fvwmorg/fvwm3/pull/756.diff — Reply to this email directly, view it on GitHub<#756>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFLGE6UUX7RMHKTDACUZFC3WHR67LANCNFSM6AAAAAAR4E44Q4>. You are receiving this because you were mentioned.Message ID: ***@***.***>