Fix intermediate deps for flavors other than debug. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intermediate dependencies (e.g. R.class) were hard coded to the debug build flavor. This commit fixes this by outputing the intermediate paths for all flavors. Note that there is no way to output only the dependencies for the flavor being build at the moment. This script is executed before any particular build (e.g. assembleDebug) is executed so we cannot know before hand what deps to load. Fortunatelly most of the time, dependencies do not conflict between flavors so loading them all should not be an issue (most of the time).
|
Thanks, this looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate dependencies (e.g. R.class) were hard coded to the debug
build flavor. This commit fixes this by outputing the intermediate paths
for all flavors.
Note that there is no way to output only the dependencies for the flavor
being build at the moment. This script is executed before any particular
build (e.g. assembleDebug) is executed so we cannot know before hand
what deps to load. Fortunatelly most of the time, dependencies do not
conflict between flavors so loading them all should not be an issue
(most of the time).