Improve shell classpath and stdlib resolution #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the ShellClassPathResolver to accept
~/.config/kotlin-language-server (instead of KotlinLanguageServer) and
kls-classpath.{sh,bat,cmd} instead of kotlinLspClasspath.{sh,bat,cmd},
along with scripts without a file extension to better adhere to Unix
conventions.
fwcd
added
enhancement
There are too many cases where manual formatting is more readable with long lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates the
ShellClasspathResolverto accept naming conventions that are more in line with standard Unix conventions, e.g.~/.config/kotlin-language-serverinstead of~/.config/KotlinLanguageServer[project root]/kls-classpathinstead of[project root]/kotlinLspClasspath.shThe old names will still be supported for backwards compatibility. Additionally,
.batand.cmdfiles are now only resolved on Windows to have the language server pick the correct classpath script depending on platform.Additionally, the PR improves the standard library resolution by filtering out source JARs when searching the local Gradle/Maven cache and by preferring the Kotlin CLI compiler stdlib over the local Gradle/Maven repository (if the user compiles Kotlin outside of Gradle/Maven, chances are that they use plain
kotlinc, thus we should use the corresponding stdlib).