Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase the max length of varchar column of ClassPathCacheEntry table #532

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

dtsuzuku-ibm
Copy link
Contributor

@dtsuzuku-ibm dtsuzuku-ibm commented Jan 11, 2024

Sometimes the length of path to compiledjar may get longer than 255.
For example, the path to the cache of this artifact https://mvnrepository.com/artifact/com.ibm.websphere.appserver.api/com.ibm.websphere.appserver.api.security.authorization.saf/1.3.78 may be like following: /Users/username/.gradle/caches/modules-2/files-2.1/com.ibm.websphere.appserver.api/com.ibm.websphere.appserver.api.security.authorization.saf/1.3.78/5fb520b6711e772218e7f9917d51d1c4347e4cf4/com.ibm.websphere.appserver.api.security.authorization.saf-1.3.78.jar

It might be better to make this limitation longer.

@github-actions github-actions bot added the dependency resolution Related to the project dependency/standard library resolver label Jan 11, 2024
Co-authored-by: fwcd <30873659+fwcd@users.noreply.github.com>
Copy link
Contributor

@daplf daplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This may require an increment to the database version since it changes the database schema.

@dtsuzuku-ibm
Copy link
Contributor Author

@fwcd @daplf

Is there any other thing to address?

Copy link
Contributor

@daplf daplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My tick carries no weight 😄 But LGTM!

@fwcd
Copy link
Owner

fwcd commented Jan 19, 2024

My tick carries no weight

I believe it does, you did design the database after all 😄

Thanks!

@fwcd fwcd merged commit 5f12bbf into fwcd:main Jan 19, 2024
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency resolution Related to the project dependency/standard library resolver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants