Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add formatting options #553

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Add formatting options #553

merged 2 commits into from
Mar 8, 2024

Conversation

henryhchchc
Copy link
Contributor

Added the following options for ktfmt:

  • kotlin.formatting.formatter: Can be ktfmt (default) or none (to disable the formatter)
  • kotlin.formatting.ktFmt.style
  • kotlin.formatting.ktFmt.indent
  • kotlin.formatting.ktFmt.maxWidth
  • kotlin.formatting.ktFmt.continuationIndent
  • kotlin.formatting.ktFmt.removeUnusedImports

@github-actions github-actions bot added the formatting Related to source code formatting label Jan 26, 2024
fwcd
fwcd reviewed Feb 19, 2024
View reviewed changes
Copy link
Owner

@fwcd fwcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor style nitpicks, otherwise this looks pretty good!

server/src/main/kotlin/org/javacs/kt/Configuration.kt Outdated Show resolved Hide resolved
server/src/main/kotlin/org/javacs/kt/KotlinWorkspaceService.kt Show resolved Hide resolved
server/src/main/kotlin/org/javacs/kt/formatting/Formatter.kt Outdated Show resolved Hide resolved
@henryhchchc
Copy link
Contributor Author

henryhchchc commented Feb 20, 2024 •
edited
Loading

Thanks for the suggestions. I made some changes as per the comments above.

@fwcd fwcd merged commit d4092aa into fwcd:main Mar 8, 2024
11 checks passed
@fwcd
Copy link
Owner

fwcd commented Mar 8, 2024

Thanks!

@fwcd fwcd added this to the 1.3.10 milestone Mar 8, 2024
@henryhchchc henryhchchc deleted the formatting-opts branch March 8, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwcd fwcd Awaiting requested review from fwcd

Assignees
No one assigned
Labels
formatting Related to source code formatting
Projects
None yet
Milestone
1.3.10
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henryhchchc @fwcd