-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javadoc in hover messages (first revision) #66
Conversation
Currently doesnt work when hovering over where its called /**, * and */ are removed from the javadoc. Needs to be refined for times when individual lines arent prefixed with *
I believe this crashes and/or doesnt work with classes/objects yet |
Hovering over class constructor calls eg |
@Strum355 Thanks for your contribution, I won't merge the PR as long as it has a |
https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/javadoc/JavaDocLocations.java this link would probably be useful, the vscode java extension seems to have issues with this repo so im having issues following it without having errors yelled at my face, but itd be a good start |
@fwcd has this functionality been added to master since this PR has been created or is this PR still good to have more work done to it? |
@Strum355 There is no equivalent functionality yet, so reviving this PR would be great. 👍 |
@fwcd we need this! |
0e7df8c
to
926144b
Compare
926144b
to
e1c1dda
Compare
…ed in the docstring
e064348
to
266d1dd
Compare
Brought this PR up to speed, it doesnt work for some situations but we can remedy that in later cases. as far as im aware, this currently only works for call expressions and function declarations, but not for class signatures from what ive seen. Class signature hover in general doesnt work in all cases eg hovering This PR can be merged to give users at least something to begin with :) |
Works for on call and declaration sites