Sparse file unit tests fail on new Apple File System #81
Comments
fhunleth
added a commit
that referenced
this issue
Nov 16, 2017
This fixes #81. The problem is that hole creation on APFS seems to vary between runs. On Linux it is predictable and the regression test was easy to write. Without this predicatability, some other way of running the tests would have to be figured out. I know of only a couple uses of sparse file support in the wild and the APFS behavior only causes those cases to be slightly slower in their updates. I can't think of a situation where the APFS behavior would break anything. If anything, the situation is slightly better since OSX didn't support sparse files before High Sierra. The non-fs dependent sparse file support code should verify that things work internally on OSX, so I'm not worried about regressions from commenting this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After upgrading the OSX High Sierra, 4 sparse file tests start failing. APFS supports sparse files, but its heuristic for determining when to make a hole is not as immediately obvious as it is with other filesystems that support sparse files. It may be necessary to disable these tests on OSX in the nearterm.
The text was updated successfully, but these errors were encountered: