Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set gnu-efi dependency for 3.0.18 #54

Closed
wants to merge 3 commits into from
Closed

Conversation

superm1
Copy link
Member

@superm1 superm1 commented Mar 25, 2024

Two issues have been reported root caused by using gnu-efi 3.0.17 and fwupd-efi 1.5. They're fixed by upgrading to 3.0.18.

Link: fwupd/fwupd#6976
Link: fwupd/fwupd#6956

There are other optimizations to be done as well, but this is the most important one initially.

Two issues have been reported root caused by using
gnu-efi 3.0.17 and fwupd-efi 1.5. They're fixed by upgrading to 3.0.18.

Link: fwupd/fwupd#6976
Link: fwupd/fwupd#6956
@superm1 superm1 requested a review from hughsie March 25, 2024 05:37
@hughsie
Copy link
Member

hughsie commented Mar 25, 2024

@superm1 how should we put gnu-efi as a BR? I'm wondering if we want to dnf install gnu-efi-devel on Fedora, or maybe we want to put gnu-efi in the fwupd container.

@superm1
Copy link
Member Author

superm1 commented Mar 25, 2024

@superm1 how should we put gnu-efi as a BR? I'm wondering if we want to dnf install gnu-efi-devel on Fedora, or maybe we want to put gnu-efi in the fwupd container.

Yeah for Fedora we need gnu-efi-devel installed in the fwupd container.
We should wait to merge until it's 3.0.18 is packaged in Fedora and Debian IMO. I've got the Debian update staged, but I'll need a sponsor to upload it for me.

As fwupd-efi requires 3.0.18 an assumption can be made that
everything fwupd-efi needs is already there.
3.0.18 should have everything we carried locally merged.
@superm1
Copy link
Member Author

superm1 commented Mar 29, 2024

closed in favor of #57

@superm1 superm1 closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants