Add IT5570 to the superio plugin #3420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
SergiiDmytruk
changed the title
superm1
reviewed
Jun 25, 2021
|
@SergiiDmytruk the $54,000,000 question -- does it still work on actual hardware? :) |
@hughsie After some fixes, it does. Most notably timeout in this case should be ~650ms and not ~250ms, but there were also wrong function calls and some stuff with quirks. |
Otherwise can't read firmware of devices whose detection depends on hardware information. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
SergiiDmytruk
force-pushed
the
wip/hughsie/superio
branch
from
160bb01
to
fd79e42
Compare
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
hughsie
force-pushed
the
wip/hughsie/superio
branch
from
fd79e42
to
3d0c5b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of pull request:
The provided implementation targets Tuxedo laptops that use IT5570. Latest attempt to support this EC was in #3413.